Adding new ring types#55
Adding new ring types#55yozmag wants to merge 2 commits intosipXcom:release-16.04from yozmag:patch-1
Conversation
Adding new Ring types according to yealink configuration parameters V80
|
We already have "yealink_ring_type", so why we need to have a duplicate? Adding Silent, Splash and Common to "yealink_ring_type" should be enough or not? |
|
There is account.X.ringtone.ring_type and phone_setting.ring_type the difference between the two is the 'Common' that is only used in account.X.ringtone.ring_type. Looks better to have have two types. What is you idea about this issue. |
|
Yes, now i see the "Common" problem. Make sense to have these two types. |
|
Yes, we have to add those, I missed that. Do you do that or I do the change? |
|
Feel free to do that. it's your PR |
|
I have changed the PR. It all ok now. |
Adding new Ring types according to yealink configuration parameters V80